Conversation
This was referenced Apr 13, 2026
4fc3fca to
d59234e
Compare
dylan-hurd-oai
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Guardian review analytics needs a Rust event shape that matches the backend schema while avoiding unnecessary PII exposure from reviewed tool calls. This PR narrows the analytics payload to the fields we intend to emit and keeps shared Guardian assessment enums in protocol instead of duplicating equivalent analytics-only enums.
What changed
risk_level,user_authorization,outcome, and command source values.target_item_idandtool_call_countnullable so the Codex event can represent cases where the app-server protocol or producer does not have those values.tty,execvesource/program, network protocol/port, and MCP connector/tool labels.codex_guardian_reviewserialization with an optionaltarget_item_idand absent removed fields.Verification
cargo test -p codex-analytics guardian_review_event_ingests_custom_fact_with_optional_target_itemcargo fmt --checkStack created with Sapling. Best reviewed with ReviewStack.