[codex] Initialize ICU data for code mode V8#17709
Merged
pakrym-oai merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
pakrym-oai
force-pushed
the
pakrym/code-mode-icu-data
branch
from
b0f13f6 to
30705f9
Compare
bolinfest
approved these changes
Apr 14, 2026
Comment on lines
+602
to
+605
| new Intl.DateTimeFormat(void 0, { | ||
| timeZone: "America/Los_Angeles", | ||
| }); | ||
| text("ok"); |
Collaborator
There was a problem hiding this comment.
Is this just proving that Intl.DateTimeFormat does not throw an exception? Why not use it with something to be sure it works for real?
pakrym-oai
force-pushed
the
pakrym/code-mode-icu-data
branch
from
30705f9 to
0736990
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link ICU data into code mode, otherwise locale-dependent methods cause a panic and a crash.