Skip to content

fix: Revert danger-full-access denylist-only mode#17732

Merged
viyatb-oai merged 6 commits intomainfrom
codex/viyatb/revert-pr-16946
Apr 14, 2026
Merged

fix: Revert danger-full-access denylist-only mode#17732
viyatb-oai merged 6 commits intomainfrom
codex/viyatb/revert-pr-16946

Conversation

@viyatb-oai
Copy link
Copy Markdown
Collaborator

Summary

  • Reverts [codex] Add danger-full-access denylist-only network mode #16946 and removes the danger-full-access denylist-only network mode.
  • Removes the corresponding config requirements, app-server protocol/schema, config API, TUI debug output, and network proxy behavior.
  • Drops stale tests that depended on the reverted mode while preserving newer managed allowlist-only coverage.

Verification

  • just write-app-server-schema
  • just fmt
  • cargo test -p codex-config network_requirements
  • cargo test -p codex-core network_proxy_spec
  • cargo test -p codex-core managed_network_proxy_decider_survives_full_access_start
  • cargo test -p codex-app-server map_requirements_toml_to_api
  • cargo test -p codex-tui debug_config_output
  • cargo test -p codex-app-server-protocol
  • just fix -p codex-config -p codex-core -p codex-app-server-protocol -p codex-app-server -p codex-tui
  • git diff --cached --check

Not run: full workspace cargo test (repo instructions ask for confirmation before that broader run).

This reverts #16946, commit 9d13d29.

Co-authored-by: Codex noreply@openai.com
@viyatb-oai viyatb-oai changed the title [codex] Revert danger-full-access denylist-only mode fix: Revert danger-full-access denylist-only mode Apr 14, 2026
@viyatb-oai viyatb-oai marked this pull request as ready for review April 14, 2026 04:23
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Co-authored-by: Codex noreply@openai.com
Copy link
Copy Markdown
Contributor

@rreichel3-oai rreichel3-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@viyatb-oai viyatb-oai merged commit 81c0bcc into main Apr 14, 2026
21 of 22 checks passed
@viyatb-oai viyatb-oai deleted the codex/viyatb/revert-pr-16946 branch April 14, 2026 16:50
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants