Support PermissionRequest hook deny interrupts#17750
Closed
abhinav-oai wants to merge 2 commits into
Closed
Conversation
Co-authored-by: Codex <noreply@openai.com>
Abort the originating turn synchronously for interrupting permission hook denials so the current turn cannot complete before cancellation lands. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decision.interrupt: truealongsidebehavior: "deny"Why
PermissionRequest hooks could deny a request, but they could not force the active agent loop to stop immediately. That made policy-driven hard stops behave differently from a user interrupt even when the hook author wanted the turn to terminate.
Impact
interrupt: trueinterrupt: truekeep the existing rejection behaviorValidation
cargo test -p codex-hooks permission_request_cargo test -p codex-core permission_request_hook_cargo run -p codex-hooks --bin write_hooks_schema_fixturesjust fix -p codex-hooksjust fix -p codex-corejust fmtStack
codex/permission-request-hooks-base