[codex] Add marketplace/remove app-server RPC#17751
Conversation
xli-oai
force-pushed
the
xli-codex/marketplace-remove-shared
branch
from
8ca2338 to
908d13c
Compare
xli-oai
force-pushed
the
xli-codex/marketplace-remove-rpc
branch
from
5286f3f to
75f90e7
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75f90e7155
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| write_installed_marketplace(codex_home.path(), "debug")?; | ||
| let installed_root = marketplace_install_root(codex_home.path()) | ||
| .join("debug") | ||
| .canonicalize()?; |
There was a problem hiding this comment.
The assertion builds installed_root via canonicalize(), but the server response returns removed_installed_root from marketplace_install_root(...) without canonicalization. On macOS, /var/... and /private/var/... may differ, so this test can fail even when behavior is correct. Compare non-canonical paths (or canonicalize both sides) to keep the test portable.
Useful? React with 👍 / 👎.
xli-oai
force-pushed
the
xli-codex/marketplace-remove-rpc
branch
from
75f90e7 to
482c0c3
Compare
|
@codex review |
2 participants
Summary
Add a new app-server
marketplace/removeRPC on top of the shared marketplace-remove implementation.This change:
MarketplaceRemoveParams/MarketplaceRemoveResponseto the app-server protocolcodex_message_processorValidation
just write-app-server-schemajust fmt