Skip to content

feat: codex sampler#17784

Merged
jif-oai merged 2 commits intomainfrom
jif/codex-sampler
Apr 14, 2026
Merged

feat: codex sampler#17784
jif-oai merged 2 commits intomainfrom
jif/codex-sampler

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented Apr 14, 2026

Add a pure sampler using the Codex auth and model config. To be used by other binary such as tape recorder

@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented Apr 14, 2026

@codex reveiw

@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented Apr 14, 2026

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6d212c9fd9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/cli/src/responses_cmd.rs Outdated
Comment thread codex-rs/cli/src/responses_cmd.rs Outdated
@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented Apr 14, 2026

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8e4c756a7c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/cli/src/main.rs
@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

PR Review Result

I reviewed this PR and did not find any blocking issues.

The change is cohesive: it adds a hidden internal responses subcommand to the CLI, wires it into dispatch, and implements a new command that reads a streaming Responses payload from stdin, authenticates via current Codex config/auth selection, and prints normalized event JSON lines. It also adds a parser-level test for command visibility/parsing and the required codex-api dependency linkage. codex-rs/cli/src/main.rsL153-L160 codex-rs/cli/src/main.rsL1016-L1032 codex-rs/cli/src/main.rsL1684-L1691 codex-rs/cli/src/responses_cmd.rsL10-L119 codex-rs/cli/Cargo.tomlL19-L28 codex-rs/Cargo.lockL1663-L1673

Checks I ran

  • ⚠️ git diff --stat e6947f85f6620390ebca1c48353773ece735c08e..6d212c9fd9958edd0db27cc32c47d3067a11cfcc (base SHA from PR info was not present locally, so this exact range could not be resolved).
  • git show --stat --oneline 6d212c9 --
  • git diff --name-only 2f6fc7c137bfa1b607b97bd932370022bea198eb..6d212c9fd9958edd0db27cc32c47d3067a11cfcc
  • ⚠️ cd codex-rs && cargo test -p codex-cli responses_subcommand_is_hidden_from_help_but_parses (build/test run hit environment disk exhaustion: No space left on device).

View task →

@jif-oai jif-oai merged commit b3ae531 into main Apr 14, 2026
20 of 22 checks passed
@jif-oai jif-oai deleted the jif/codex-sampler branch April 14, 2026 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant