[Cross-Platform][Codex] Render high-risk MCP elicitation warnings in TUI#17850
Open
kieraj-oai wants to merge 1 commit intomainfrom
Open
[Cross-Platform][Codex] Render high-risk MCP elicitation warnings in TUI#17850kieraj-oai wants to merge 1 commit intomainfrom
kieraj-oai wants to merge 1 commit intomainfrom
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
kieraj-oai
force-pushed
the
km-high-risk-elicitations-2
branch
from
9a11c95 to
18be024
Compare
Comment on lines
754
to
756
| { | ||
| self.analytics_events_client.track_request( | ||
| connection_id.0, | ||
| connection_request_id.connection_id.0, | ||
| request_id.clone(), | ||
| codex_request.clone(), |
Collaborator
There was a problem hiding this comment.
seems like some breakage at HEAD, can we sync the PR to latest and revert this?
Author
There was a problem hiding this comment.
This was an unrelated failure with the build i was seeing locally that this addressed, i figured i'd fix it here. Happy to remove or separate into its own PR if that's better.
kieraj-oai
force-pushed
the
km-high-risk-elicitations-2
branch
3 times, most recently
from
4d52101 to
640d844
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
kieraj-oai
force-pushed
the
km-high-risk-elicitations-2
branch
from
640d844 to
6cb51c7
Compare
mzeng-openai
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
riskLevelandsubtitlethrough elicitation _meta into the TUI request modelsubtitlebelow the message and render high-risk messages in red with a⚠prefixTesting
cargo test -p codex-tui mcp_server_elicitation