Skip to content

Refactor auth providers to mutate request headers#17866

Merged
celia-oai merged 3 commits intomainfrom
pakrym/move-auth-headers-into-provider
Apr 15, 2026
Merged

Refactor auth providers to mutate request headers#17866
celia-oai merged 3 commits intomainfrom
pakrym/move-auth-headers-into-provider

Conversation

@pakrym-oai
Copy link
Copy Markdown
Collaborator

Summary

  • Move auth header construction into the AuthProvider::add_auth_headers contract.
  • Inline CoreAuthProvider header mutation in its provider impl and remove the shared header-map helper.
  • Update HTTP, websocket, file upload, sideband websocket, and test auth callsites to use the provider method.
  • Add direct coverage for CoreAuthProvider auth header mutation.

Testing

  • just fmt
  • cargo test -p codex-api
  • cargo test -p codex-core client::tests::auth_request_telemetry_context_tracks_attached_auth_and_retry_phase
  • cargo test -p codex-core failed on unrelated/reproducible tools::handlers::multi_agents::tests::multi_agent_v2_followup_task_interrupts_busy_child_without_losing_message

@celia-oai celia-oai enabled auto-merge (squash) April 15, 2026 18:12
@celia-oai celia-oai disabled auto-merge April 15, 2026 18:38
@celia-oai celia-oai merged commit f5e8eac into main Apr 15, 2026
29 of 36 checks passed
@celia-oai celia-oai deleted the pakrym/move-auth-headers-into-provider branch April 15, 2026 18:52
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants