Disable hooks in guardian review sessions#17872
Merged
abhinav-oai merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
Guardian review sessions should not inherit Codex hooks from the parent config. Disable the hooks feature when building the spawned guardian config and add a regression test covering a parent config with hooks enabled. Co-authored-by: Codex <noreply@openai.com>
alexsong-oai
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Disable
Feature::CodexHookswhen building guardian review session configWhy
Guardian review sessions were respecting the Stop hook and could ingest synthetic
<hook_prompt>user turns Guardian should ignore hooks, while the main session and regular subagents continue to respect themIn other words Guardian was getting ralph-looped