feat: Support alternate marketplace manifests and local string#17885
Merged
feat: Support alternate marketplace manifests and local string#17885
Conversation
Collaborator
xl-openai
commented
Apr 15, 2026
xl-openai
commented
- Discover marketplace manifests from different supported layout paths instead of only .agents/plugins/marketplace.json.
- Accept local plugin sources written either as { source: "local", path: ... } or as a direct string path.
- Skip unsupported or invalid plugin source entries without failing the entire marketplace, and keep valid local plugins loadable.
xli-oai
approved these changes
Apr 15, 2026
xl-openai
force-pushed
the
xl/plugins
branch
2 times, most recently
from
2273122 to
b58561e
Compare
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Treat missing plugin source as unsupported, not fatal
A plugin entry without a source key still fails deserialization for the whole manifest because source is required here. That contradicts the stated goal to skip invalid/unsupported plugin source entries and keep the marketplace loadable. One malformed plugin can still block listing/loading all others.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.