[TUI] add external config migration prompt when start TUI#17891
[TUI] add external config migration prompt when start TUI#17891alexsong-oai merged 23 commits intomainfrom
Conversation
alexsong-oai
changed the title
|
@codex review |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9a96f5974
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (plugin_id, enabled) in plugins.iter().filter_map(|(plugin_id, plugin_config)| { | ||
| plugin_config | ||
| .get("enabled") | ||
| .and_then(TomlValue::as_bool) | ||
| .map(|enabled| (plugin_id, enabled)) |
There was a problem hiding this comment.
configured_plugin_ids only records plugin entries that explicitly set enabled in config.toml. But plugin config defaults enabled to true, so a valid section like [plugins."formatter@acme-tools"] (without enabled) is still configured. This causes detect to treat it as unmigrated, re-showing migration prompts and attempting duplicate plugin migration.
Useful? React with 👍 / 👎.
| /// Enable plugins. | ||
| Plugins, | ||
| /// Show the startup prompt for migrating external agent config into Codex. | ||
| ExternalMigrate, |
There was a problem hiding this comment.
Feature flags shouldn't be verbs
| session_selection, | ||
| feedback, | ||
| should_show_trust_screen, // Proxy to: is it a first run in this directory? | ||
| should_show_trust_screen_flag, // Preserve the startup-time trust NUX signal before onboarding |
There was a problem hiding this comment.
@etraut-openai FYI, I introduced a param entered_trust_nux, to track whether the user entered the trust screen and to display the migration prompt only if they did
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57347f86dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
etraut-openai
left a comment
etraut-openai
left a comment
There was a problem hiding this comment.
Overall, looks good. I left a few suggestions for minor polish improvements.
4 participants
Uh oh!
There was an error while loading. Please reload this page.