Conversation
leoshimo-oai
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#17763 moved sandbox-state delivery for MCP tool calls to request
_metavia thecodex/sandbox-state-metaexperimental capability. Keeping the oldercodex/sandbox-statecapability meant Codex still maintained a second transport that pushed updates with the customcodex/sandbox-state/updaterequest at server startup and when the session sandbox policy changed.That duplicate MCP path is redundant with the per-tool-call metadata path and makes the sandbox-state contract larger than needed. The existing managed network proxy refresh on sandbox-policy changes is still needed, so this keeps that behavior separate from the removed MCP notification.
What Changed
MCP_SANDBOX_STATE_CAPABILITYandMCP_SANDBOX_STATE_METHODconstants.codex/sandbox-stateduring MCP initialization and stopped sendingcodex/sandbox-state/updateat server startup.McpConnectionManager::notify_sandbox_state_changeplumbing while preserving the managed network proxy refresh when a user turn changes sandbox policy.McpConnectionManager::newso startup paths pass only the initialSandboxPolicyneeded for MCP elicitation state.codex/sandbox-state-metasupport intact; servers that opt in still receive the currentSandboxStateon tool-call request_meta(remaining call path).Verification
cargo test -p codex-core new_turn_refreshes_managed_network_proxy_for_sandbox_changecargo test -p codex-mcp