Conversation
pakrym-oai
reviewed
Apr 15, 2026
Collaborator
There was a problem hiding this comment.
can you also unify base.contains("openai.azure and matches_azure_responses_base_url
Collaborator
Author
There was a problem hiding this comment.
good call: fixed!
pakrym-oai
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
While reviewing #17958, the helper name
is_azure_responses_wire_base_urllooked misleading because the helper returns true for either theazureprovider name or an Azure Responsesbase_url. The new name makes both inputs part of the contract.What
is_azure_responses_wire_base_urltois_azure_responses_provider.openai.azure.marker intomatches_azure_responses_base_urlso all base URL marker matching is centralized.Provider::is_azure_responses_endpoint()behavior unchanged.Verification
name.eq_ignore_ascii_case("azure")still returns true before consultingbase_url,Nonestill returns false, base URLs are still lowercased before marker matching, and the same Azure marker set is checked.cargo test -p codex-api.