Persist and prewarm agent tasks per thread#17978
Open
adrian-openai wants to merge 3 commits intodev/adrian/codex/agent-identity-register-taskfrom
Open
Persist and prewarm agent tasks per thread#17978adrian-openai wants to merge 3 commits intodev/adrian/codex/agent-identity-register-taskfrom
adrian-openai wants to merge 3 commits intodev/adrian/codex/agent-identity-register-taskfrom
Conversation
efrazer-oai
reviewed
Apr 15, 2026
| use tokio::time::timeout; | ||
|
|
||
| const DEFAULT_READ_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(10); | ||
| const DEFAULT_READ_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(20); |
Contributor
There was a problem hiding this comment.
why do we need to change all the test timings for this? was it flaky?
Contributor
Author
There was a problem hiding this comment.
I believe this was a codex artifact. Rolling this back after making sure that things aren't flaky.
efrazer-oai
reviewed
Apr 15, 2026
| use tokio::time::timeout; | ||
|
|
||
| const DEFAULT_READ_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(10); | ||
| const DEFAULT_READ_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(20); |
Contributor
There was a problem hiding this comment.
why do we need to change all the test timings for this? was it flaky?
Contributor
Author
There was a problem hiding this comment.
Same as above. Nice catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing