[1/8] Add MCP server environment config#17984
Closed
aibrahim-oai wants to merge 2 commits intoopenai:mainfrom
Closed
[1/8] Add MCP server environment config#17984aibrahim-oai wants to merge 2 commits intoopenai:mainfrom
aibrahim-oai wants to merge 2 commits intoopenai:mainfrom
Conversation
pakrym-oai
reviewed
Apr 16, 2026
|
|
||
| /// Where Codex should start this MCP server. | ||
| #[serde(default, skip_serializing_if = "McpServerEnvironment::is_local")] | ||
| pub environment: McpServerEnvironment, |
Collaborator
There was a problem hiding this comment.
make it a string.
experimental_environment too.
pakrym-oai
approved these changes
Apr 16, 2026
Introduce the MCP server environment setting and thread the default local value through config serialization, schema generation, and existing config fixtures. Co-authored-by: Codex <noreply@openai.com>
95d69db to
e776798
Compare
Collaborator
Author
|
Recreated as #18085 from an openai/codex head branch so internal CI uses the normal credentials path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack