Skip to content

nit: get rid of an expect#18144

Merged
jif-oai merged 1 commit intomainfrom
jif/nit-expect
Apr 16, 2026
Merged

nit: get rid of an expect#18144
jif-oai merged 1 commit intomainfrom
jif/nit-expect

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented Apr 16, 2026

Get rid of an expect() that caused a panic in the TUI

Screenshot 2026-04-16 at 15 30 20

Basically in from_absolute_path there is a absolutize::absolutize that calls a current_dir() . But the dir in which Codex was running got re-generated (because of Codex I guess but I can't exactly see the source). So current_dir() returns an ENOENT and 💥

@jif-oai jif-oai merged commit 895e2d0 into main Apr 16, 2026
30 of 36 checks passed
@jif-oai jif-oai deleted the jif/nit-expect branch April 16, 2026 14:51
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant