[codex] Explore executor-bound path API#18241
Draft
starr-openai wants to merge 9 commits intomainfrom
Draft
Conversation
5646ebf to
9e5f1c3
Compare
9e5f1c3 to
c6a6f54
Compare
Adds executor-bound path helpers and threads them through skills, config loading, AGENTS.md loading, view_image, and apply_patch to evaluate the API blast radius. Harness-owned reads use explicit unsandboxed access while tool-call paths carry the sandbox context through the path access wrapper. Validation: just fmt; git diff --check. Co-authored-by: Codex <noreply@openai.com>
c6a6f54 to
150cb18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft follow-up stacked on #18209 to explore the blast radius of an executor-bound path API.
This adds
ExecutorPath,ExecutorPathRef, andExecutorPathAccessas an explicit split between path identity and operation access mode. The exploratory conversions use:path.unsandboxed()for Codex harness/config reads such as config layers, AGENTS.md, skills, agent roles, and git trust discoverypath.with_sandbox(sandbox)for model/tool initiated file operations such asview_imageandapply_patchWhat changed
view_imageto read through a sandboxed executor path access object.apply_patchinternals to use sandboxed executor path access for read/stat/write/create/delete operations.Notes
This is intentionally broad and exploratory. The goal is to make the API pressure visible before deciding what should be trimmed into a reviewable final shape.
Validation
cd codex-rs && just fmtgit diff --checkTests/builds were not run locally.