Sync local plugin imports, async remote imports, refresh caches after…#18246
Sync local plugin imports, async remote imports, refresh caches after…#18246alexsong-oai merged 10 commits intomainfrom
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
| ); | ||
| return; | ||
| } | ||
| ServerNotification::ExternalAgentConfigImportCompleted(_) => { |
There was a problem hiding this comment.
FYI @xl-openai, adding a notification when import completed and refresh the plugins state on TUI
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
… import
Why
externalAgentConfig/importused to spawn plugin imports in the background and return immediately. That meant local marketplace imports could still be in flight when the caller refreshed plugin state, so newly imported plugins would not show up right away.This change makes local marketplace imports complete before the RPC returns, while keeping remote marketplace imports asynchronous so we do not block on remote fetches.
What changed
externalAgentConfig/importplugin/listreloads fresh stateis_local_marketplace_source(...)instead of re-exporting the internal enumVerification
cargo test -p codex-app-server-protocolcargo test -p codex-core(currently fails an existing unrelated test:config_loader::tests::cli_override_can_update_project_local_mcp_server_when_project_is_trusted)cargo test(currently fails existingcodex-app-serverintegration tests in MCP/skills/thread-start areas, plus the unrelatedcodex-corefailure above)