Support Ctrl+P/Ctrl+N in resume picker#18267
Merged
etraut-openai merged 4 commits intomainfrom Apr 17, 2026
Merged
Conversation
etraut-openai
commented
Apr 17, 2026
fcoury-oai
approved these changes
Apr 17, 2026
Contributor
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
Tested and works. Code looks good. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18179.
Why
The fullscreen
/resumepicker accepted Up/Down navigation but ignored Ctrl+P/Ctrl+N, which made it inconsistent with other TUI selection flows such asListSelectionView-backed pickers and composer navigation.What Changed
Updated
codex-rs/tui/src/resume_picker.rsso the resume picker treats Ctrl+P/Ctrl+N as aliases for Up/Down, including the raw^P/^Ncontrol-character events some terminals emit without a CONTROL modifier.