Skip to content

codex: move thread/name/set and thread/memoryModeSet into ThreadStore#18361

Merged
wiltzius-openai merged 1 commit intomainfrom
wiltzius/codex/thread-store-unloaded-writes
Apr 20, 2026
Merged

codex: move thread/name/set and thread/memoryModeSet into ThreadStore#18361
wiltzius-openai merged 1 commit intomainfrom
wiltzius/codex/thread-store-unloaded-writes

Conversation

@wiltzius-openai
Copy link
Copy Markdown
Contributor

@wiltzius-openai wiltzius-openai commented Apr 17, 2026 •
edited
Loading

  • Migrates unloaded thread/name/set and thread/memoryModeSet app-server writes behind the generic ThreadStore::update_thread_metadata API rather than adding one-off store methods for setting thread name or memory mode.
  • Implements the local ThreadStore metadata patch path for thread name and memory mode, including rollout append, legacy name index updates, SessionMeta validation/update, SQLite reconciliation, and re-reading the stored thread.
  • Adds focused local thread-store unit coverage plus app-server integration coverage for the migrated unloaded write paths.

@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-unloaded-writes branch from faa5224 to 253361e Compare April 17, 2026 18:14
@wiltzius-openai
Copy link
Copy Markdown
Contributor Author

wiltzius-openai commented Apr 17, 2026

@codex review

@wiltzius-openai wiltzius-openai marked this pull request as ready for review April 17, 2026 18:35
@wiltzius-openai wiltzius-openai enabled auto-merge (squash) April 17, 2026 18:35
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 253361ed58

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/thread-store/src/local/update_thread_metadata.rs Outdated
Comment thread codex-rs/thread-store/src/local/update_thread_metadata.rs Outdated
Comment thread codex-rs/thread-store/src/local/update_thread_metadata.rs Outdated
Comment thread codex-rs/thread-store/src/local/update_thread_metadata.rs Outdated
Comment thread codex-rs/thread-store/src/local/update_thread_metadata.rs Outdated
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-unloaded-writes branch from 253361e to 54ec651 Compare April 17, 2026 20:32
@wiltzius-openai wiltzius-openai force-pushed the wiltzius/codex/thread-store-unloaded-writes branch from 54ec651 to 132b88d Compare April 17, 2026 20:36
@wiltzius-openai
Copy link
Copy Markdown
Contributor Author

wiltzius-openai commented Apr 17, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

chatgpt-codex-connector Bot commented Apr 17, 2026

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

chatgpt-codex-connector Bot commented Apr 17, 2026

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@wiltzius-openai wiltzius-openai changed the title codex: move unloaded thread writes into store codex: move thread/name/set and thread/memoryModeSet into ThreadStore Apr 17, 2026
@wiltzius-openai wiltzius-openai mentioned this pull request Apr 17, 2026
Draft
aibrahim-oai
aibrahim-oai approved these changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aibrahim-oai aibrahim-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean!

@wiltzius-openai wiltzius-openai merged commit ac7c9a6 into main Apr 20, 2026
35 of 36 checks passed
@wiltzius-openai wiltzius-openai deleted the wiltzius/codex/thread-store-unloaded-writes branch April 20, 2026 16:50
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@aibrahim-oai aibrahim-oai aibrahim-oai approved these changes

Assignees

@starr-openai starr-openai

@aibrahim-oai aibrahim-oai

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wiltzius-openai @aibrahim-oai @starr-openai