Skip to content

Show action required in terminal title#18372

Merged
canvrno-oai merged 8 commits intomainfrom
canvrno/18162-action-required-title
Apr 27, 2026
Merged

Show action required in terminal title#18372
canvrno-oai merged 8 commits intomainfrom
canvrno/18162-action-required-title

Conversation

@canvrno-oai
Copy link
Copy Markdown
Contributor

@canvrno-oai canvrno-oai commented Apr 17, 2026

Implements #18162

This updates the TUI terminal title to show an explicit action-required state when Codex is blocked on user approval or input. The terminal title now uses the activity title item to cover both active work and blocked-on-user states, while still accepting the legacy spinner config value.

Changes

  • Rename the terminal title item from spinner to activity while preserving legacy config compatibility
  • Show [ ! ] Action Required while approval or input overlays are active, with a blinking [ . ] alternate state
  • Suppress the normal working spinner while Codex is blocked on user action
  • Add targeted coverage for action-required title behavior and legacy title-item parsing

Testing

  • Trigger an approval or input modal and confirm the tab title alternates between [ ! ] Action Required and [ . ] Action Required
  • Disable the activity title item and confirm the action-required title does not appear
  • Resolve the prompt and confirm the title returns to the normal spinning/idel state
Screen.Recording.2026-04-17.at.1.32.08.PM.mov

@canvrno-oai canvrno-oai force-pushed the canvrno/18162-action-required-title branch from 10a7667 to 95a5083 Compare April 22, 2026 00:37
@canvrno-oai
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a711dc085a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/bottom_pane/app_link_view.rs Outdated
Comment thread codex-rs/tui/src/chatwidget/status_surfaces.rs Outdated
Comment thread codex-rs/tui/src/bottom_pane/action_required_title.rs
@canvrno-oai
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7542fb6e12

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tui/src/chatwidget/status_surfaces.rs
@canvrno-oai canvrno-oai marked this pull request as ready for review April 23, 2026 02:00
@fcoury-oai fcoury-oai self-assigned this Apr 24, 2026
Copy link
Copy Markdown
Contributor

@fcoury-oai fcoury-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According again to Codex we missed a documentation change:

The smaller issue is stale wording in config docs/schema.

The code now wants users to think of the terminal-title item as activity, with spinner kept as a legacy alias. It also uses project-name as the canonical project item. But the config documentation still says the defaults are spinner and project.

From the user’s perspective: if they look at generated config docs or schema help, they’ll be taught the old names instead of the new recommended ones. Existing configs still work, so this is not a runtime bug, just confusing documentation.

codex-rs/core/src/config/mod.rs:375
codex-rs/core/config.schema.json:2227

The code looks good and I tested it and it works fine. Approved with this minor nit.

@canvrno-oai canvrno-oai requested a review from a team as a code owner April 24, 2026 19:09
@canvrno-oai
Copy link
Copy Markdown
Contributor Author

Will require approval from @openai/codex-core-agent-team due to config changes - no change to any ts-rs-exported API shape or app-server protocol surface.

@canvrno-oai canvrno-oai force-pushed the canvrno/18162-action-required-title branch from b173cf2 to dd16989 Compare April 27, 2026 17:44
@canvrno-oai canvrno-oai enabled auto-merge (squash) April 27, 2026 21:41
@canvrno-oai canvrno-oai disabled auto-merge April 27, 2026 21:41
@canvrno-oai canvrno-oai merged commit e64c765 into main Apr 27, 2026
45 of 47 checks passed
@canvrno-oai canvrno-oai deleted the canvrno/18162-action-required-title branch April 27, 2026 22:27
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants