Show action required in terminal title#18372
Conversation
10a7667 to
95a5083
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a711dc085a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7542fb6e12
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fcoury-oai
left a comment
There was a problem hiding this comment.
According again to Codex we missed a documentation change:
The smaller issue is stale wording in config docs/schema.
The code now wants users to think of the terminal-title item as activity, with spinner kept as a legacy alias. It also uses project-name as the canonical project item. But the config documentation still says the defaults are spinner and project.
From the user’s perspective: if they look at generated config docs or schema help, they’ll be taught the old names instead of the new recommended ones. Existing configs still work, so this is not a runtime bug, just confusing documentation.
codex-rs/core/src/config/mod.rs:375
codex-rs/core/config.schema.json:2227
The code looks good and I tested it and it works fine. Approved with this minor nit.
|
Will require approval from @openai/codex-core-agent-team due to config changes - no change to any ts-rs-exported API shape or app-server protocol surface. |
b173cf2 to
dd16989
Compare
Implements #18162
This updates the TUI terminal title to show an explicit action-required state when Codex is blocked on user approval or input. The terminal title now uses the activity title item to cover both active work and blocked-on-user states, while still accepting the legacy spinner config value.
Changes
spinnertoactivitywhile preserving legacy config compatibility[ ! ] Action Requiredwhile approval or input overlays are active, with a blinking[ . ]alternate stateTesting
[ ! ] Action Requiredand[ . ] Action RequiredScreen.Recording.2026-04-17.at.1.32.08.PM.mov