Skip to content

Skip .tsh in Windows sandbox profile read roots#18414

Closed
efrazer-oai wants to merge 1 commit intomainfrom
efrazer/windows-sandbox-skip-tsh
Closed

Skip .tsh in Windows sandbox profile read roots#18414
efrazer-oai wants to merge 1 commit intomainfrom
efrazer/windows-sandbox-skip-tsh

Conversation

@efrazer-oai
Copy link
Copy Markdown
Contributor

Summary

  • Add .tsh to the Windows sandbox user-profile read-root exclusions.
  • Extend the existing profile-read-root test so Teleport state is covered beside .ssh.

Why

Teleport stores local client state under the human user's .tsh directory. The Windows sandbox setup should not grant CodexSandboxUsers inherited read ACLs on that directory while scanning top-level profile entries.

Testing

  • just fmt
  • cargo test -p codex-windows-sandbox --lib
  • just fix -p codex-windows-sandbox

Note

  • just bazel-lock-update and just bazel-lock-check currently fail locally before evaluating this change because Bazel cannot load @@rules_rs++toolchains+cargo_macos_aarch64_1_93_0//:bin/cargo.

@efrazer-oai
Copy link
Copy Markdown
Contributor Author

Closing in favor of a smaller Windows sandbox fix that prevents USERPROFILE itself from becoming an ACL root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant