[codex] Describe uninstalled cross-repo plugin reads#18449
Merged
Conversation
xli-oai
added
the
oai
ChatGPT Codex Connector
xl-openai
approved these changes
Apr 18, 2026
xli-oai
force-pushed
the
xli-codex/cross-repo-plugin-read-description
branch
from
67c4ec7 to
c6b2b51
Compare
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PluginDetail.descriptionin core for uninstalled cross-repo plugins when detailed fields are unavailable until install.details_unavailable_reasonas the structured signal while app-server forwards the description normally.Why
Uninstalled cross-repo plugins intentionally return sparse detail data so listing/reading does not clone the plugin source. Without a description, Desktop and TUI detail pages look like an ordinary empty plugin. This gives users a concrete explanation and source pointer while keeping the existing structured reason available for callers.
Validation
just fmtcargo test -p codex-core read_plugin_for_config_uninstalled_git_source_requires_install_without_cloningcargo test -p codex-app-server plugin_read --test alljust fix -p codex-corejust fix -p codex-app-serverNote:
cargo test -p codex-app-serverwas also attempted before the latest refactor and failed broadly in unrelated v2 thread/realtime/review/skills suites; the new plugin-read test passed in that run as well.