Conversation
bolinfest
commented
Aug 5, 2025
| pub model: Option<String>, | ||
|
|
||
| /// Convenience flag to select the local open source model provider. | ||
| /// Equivalent to -c model_provider=oss; verifies a local Ollama server is |
Collaborator
Author
There was a problem hiding this comment.
should really be a macro for --profile oss so you can have a default model for your oss profile that differs from the default model for your default profile
bolinfest
commented
Aug 5, 2025
| eprintln!(""); | ||
| } | ||
|
|
||
| if cli.oss { |
Collaborator
Author
There was a problem hiding this comment.
Also, we need a comparable change to codex exec, but it seemed easier to test it out here first.
easong-openai
approved these changes
Aug 5, 2025
Collaborator
Author
|
This was addressed by #1848 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds off of the work in #1813, but ports only the business logic. Introduces a new built-in provider named
ossrather than trying to write one to the user'sconfig.toml.