Support codex app on macOS (Intel) and Windows#18500
Open
etraut-openai wants to merge 5 commits intomainfrom
Open
Support codex app on macOS (Intel) and Windows#18500etraut-openai wants to merge 5 commits intomainfrom
codex app on macOS (Intel) and Windows#18500etraut-openai wants to merge 5 commits intomainfrom
Conversation
etraut-openai
changed the title
codex app for Intel Macs
etraut-openai
changed the title
codex app for Intel Macscodex app for Intel-based Macs
etraut-openai
changed the title
codex app for Intel-based Macs
etraut-openai
changed the title
etraut-openai
changed the title
codex app on macOS (Intel) and Windows
Contributor
|
I am not sure if you were able to test it on Windows but I got the error below even thought he URL opened fine. 
I learned that in Windows explorer.exe can return error code 1 even if it successfully open the URL. After fixing that, I found that we had a path canonicalization bug: 
I opened a PR against your PR with the fix. Be welcome to accept it or implement the fix yourself. With this code it correctly identifies whether it's installed or not, opens either the install URL or the app and displays the correct path. 
|
Collaborator
Author
|
@fcoury-oai , thanks for testing it on Windows. Please feel free to push fixes directly to my branch. |
## Summary This updates the Windows Codex Desktop launcher path handling. Store URLs now open through PowerShell, while shell app targets still use Explorer because Explorer can hand off shell targets successfully while returning a nonzero exit status. It also normalizes extended Windows workspace paths before printing follow-up instructions, so users see standard drive and UNC paths after opening or installing Codex Desktop. ## Validation - `just fmt` - `cargo test -p codex-cli`
Collaborator
Author
|
I just merged your PR onto mine! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex appshould be a platform-aware entry point for opening Codex Desktop or helping users install it. Before this change, the command only existed on macOS and its default installer URL always pointed at the Apple Silicon DMG, which sent Intel Mac users to the wrong build.This updates the macOS path to choose the Apple Silicon or Intel DMG based on the detected processor, while keeping
--download-urlas an advanced override. It also enablescodex appon Windows, where the CLI opens an installed Codex Desktop app when available and otherwise opens the Windows installer URL.