Avoid redundant memory enable notice#18580
Merged
etraut-openai merged 2 commits intomainfrom Apr 19, 2026
Merged
Conversation
fcoury-oai
approved these changes
Apr 19, 2026
Contributor
fcoury-oai
left a comment
fcoury-oai
left a comment
There was a problem hiding this comment.
Replicated and confirmed the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18554.
The
/experimentalmenu can submit the full experimental feature state even when the user presses Enter without toggling anything. Previously, Codex showedMemories will be enabled in the next session.whenever the submitted updates includedFeature::MemoryTool = true, so sessions where Memories were already enabled could show a redundant warning on a no-op save.This change records whether
Feature::MemoryToolwas enabled before applying feature updates and only emits the next-session notice when Memories actually transitions from disabled to enabled.