Use app server metadata for fork parent titles#18632
Conversation
fcoury-oai
left a comment
There was a problem hiding this comment.
Tested fork with a Codex App-generated thread and it worked flawlessly.
Code looks good! 👍
b542e30 to
2e4da7e
Compare
There was a problem hiding this comment.
💡 Codex Review
codex/codex-rs/tui/src/chatwidget.rs
Line 2194 in f59f2f6
handle_thread_session_quiet still calls on_session_configured_with_display, but this commit renamed the helper to on_session_configured_with_display_and_fork_parent_title and removed the old method. This leaves an unresolved method call, so codex-tui cannot compile and quiet-session handling is broken.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
[codex] Addressed in b27f89d: handle_thread_session_quiet now calls on_session_configured_with_display_and_fork_parent_title and passes through the fork parent title. |
Problem
The TUI resolved fork parent titles from local CODEX_HOME metadata, which could show missing or stale titles when app-server metadata is authoritative.
This is a lingering bug left over from the migration of the TUI to the app-server interface. I found it when I asked Codex to review all places where the TUI code was still directly accessing the local CODEX_HOME.
Solution
Route fork parent title metadata through the app-server session state and render only that supplied title, with focused snapshot coverage for stale local metadata.
Testing
I manually tested by renaming a thread then forking it and confirming that the "forked from" message indicated the parent thread's name.