Skip to content

Use app server metadata for fork parent titles#18632

Merged
etraut-openai merged 15 commits intomainfrom
etraut/fork-parent-title-app-server
Apr 20, 2026
Merged

Use app server metadata for fork parent titles#18632
etraut-openai merged 15 commits intomainfrom
etraut/fork-parent-title-app-server

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai commented Apr 20, 2026

Problem

The TUI resolved fork parent titles from local CODEX_HOME metadata, which could show missing or stale titles when app-server metadata is authoritative.

This is a lingering bug left over from the migration of the TUI to the app-server interface. I found it when I asked Codex to review all places where the TUI code was still directly accessing the local CODEX_HOME.

Solution

Route fork parent title metadata through the app-server session state and render only that supplied title, with focused snapshot coverage for stale local metadata.

Testing

I manually tested by renaming a thread then forking it and confirming that the "forked from" message indicated the parent thread's name.

etraut-openai added a commit that referenced this pull request Apr 20, 2026
Copy link
Copy Markdown
Contributor

@fcoury-oai fcoury-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested fork with a Codex App-generated thread and it worked flawlessly.

Code looks good! 👍

@etraut-openai etraut-openai force-pushed the etraut/fork-parent-title-app-server branch from b542e30 to 2e4da7e Compare April 20, 2026 15:25
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

self.on_session_configured_with_display(

P0 Badge Restore quiet-session handler call target

handle_thread_session_quiet still calls on_session_configured_with_display, but this commit renamed the helper to on_session_configured_with_display_and_fork_parent_title and removed the old method. This leaves an unresolved method call, so codex-tui cannot compile and quiet-session handling is broken.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@etraut-openai
Copy link
Copy Markdown
Collaborator Author

[codex] Addressed in b27f89d: handle_thread_session_quiet now calls on_session_configured_with_display_and_fork_parent_title and passes through the fork parent title.

@etraut-openai etraut-openai requested a review from a team as a code owner April 20, 2026 19:27
@etraut-openai etraut-openai merged commit b8e78e8 into main Apr 20, 2026
25 checks passed
@etraut-openai etraut-openai deleted the etraut/fork-parent-title-app-server branch April 20, 2026 22:37
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants