Skip to content

Use app server thread names in TUI picker#18633

Merged
etraut-openai merged 1 commit intomainfrom
etraut/tui-app-server-thread-names
Apr 20, 2026
Merged

Use app server thread names in TUI picker#18633
etraut-openai merged 1 commit intomainfrom
etraut/tui-app-server-thread-names

Conversation

@etraut-openai
Copy link
Copy Markdown
Collaborator

@etraut-openai etraut-openai commented Apr 20, 2026

Problem

The TUI resume/fork picker was backfilling thread names from local rollout indexes. This was left over from before the TUI was moved to the app server. It should be using app-server APIs because the TUI might be connected to a remote connection.

This bug wasn't (yet) reported by a user. I found it by asking Codex to review places in the TUI code where it was still directly accessing the CODEX_HOME directory rather than going through app-server APIs.

Solution

The resume picker and session lookups should use app-server thread APIs only. Remove legacy rollout name/list backfills, and avoid local name reads in fork history.

Testing

I manually tested codex resume and codex resume --all to look for functional or performance regressions in the resume picker.

Copy link
Copy Markdown
Contributor

@fcoury-oai fcoury-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tested and made sure the threads and thread names remained the same after this change, specially the ones created by the Codex App.

@etraut-openai etraut-openai merged commit 43a69c5 into main Apr 20, 2026
35 of 36 checks passed
@etraut-openai etraut-openai deleted the etraut/tui-app-server-thread-names branch April 20, 2026 15:16
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants