Skip to content

[codex] Fix agent identity auth test fixture#18697

Merged
adrian-openai merged 1 commit intomainfrom
dev/adrian/codex/fix-code-mode-wait-terminate
Apr 20, 2026
Merged

[codex] Fix agent identity auth test fixture#18697
adrian-openai merged 1 commit intomainfrom
dev/adrian/codex/fix-code-mode-wait-terminate

Conversation

@adrian-openai
Copy link
Copy Markdown
Contributor

@adrian-openai adrian-openai commented Apr 20, 2026

Summary

  • Add the missing background_task_id: None field to the AgentIdentityAuthRecord fixture introduced in auth_tests.rs.

Why

  • Current main fails Bazel/rust-ci compile paths after the background-task auth field landed and a later auth test fixture constructed AgentIdentityAuthRecord without that new field.
  • I intentionally removed the earlier broader CI-stability edits from this PR. The code-mode timeout, external-agent migration snapshot, and MCP resource timeout failures appear to be general/flaky or unrelated to the agent identity merge stack rather than cleanly caused by it.

Validation

  • cargo test -p codex-login dummy_chatgpt_auth_does_not_create_cwd_auth_json_when_identity_is_set -- --nocapture
  • just fmt

@adrian-openai adrian-openai force-pushed the dev/adrian/codex/fix-code-mode-wait-terminate branch from 2269d34 to 5402218 Compare April 20, 2026 16:54
@adrian-openai adrian-openai changed the title [codex] Stabilize main CI test failures [codex] Fix agent identity auth test fixture Apr 20, 2026
@adrian-openai adrian-openai marked this pull request as ready for review April 20, 2026 16:56
@adrian-openai adrian-openai merged commit 6b17adc into main Apr 20, 2026
25 checks passed
@adrian-openai adrian-openai deleted the dev/adrian/codex/fix-code-mode-wait-terminate branch April 20, 2026 18:06
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants