Skip to content

Fix stale model test fixtures#18719

Merged
aibrahim-oai merged 3 commits intomainfrom
dev/fix-main-model-tests
Apr 20, 2026
Merged

Fix stale model test fixtures#18719
aibrahim-oai merged 3 commits intomainfrom
dev/fix-main-model-tests

Conversation

@aibrahim-oai
Copy link
Copy Markdown
Collaborator

@aibrahim-oai aibrahim-oai commented Apr 20, 2026

Fixes stale test fixtures left after the active bundled model catalog updates in #18586 and #18388. Those changes made gpt-5.4 the current default and removed several older hardcoded slugs, which left Windows Bazel shards failing TUI and config tests.

What changed:

  • Refresh TUI model migration, availability NUX, plan-mode, status, and snapshot fixtures to use active bundled model slugs.
  • Update the config edit test expectation for the TOML-quoted "gpt-5.2" migration key.
  • Move the model catalog tests into codex-rs/tui/src/app/tests/model_catalog.rs so touching them does not trip the blob-size policy for app.rs.

Verification:

  • CI Bazel/lint checks are expected to cover the affected test shards.

@aibrahim-oai aibrahim-oai requested a review from a team as a code owner April 20, 2026 19:20
@aibrahim-oai aibrahim-oai force-pushed the dev/fix-main-model-tests branch 3 times, most recently from cf37e03 to 90ed129 Compare April 20, 2026 20:27
@aibrahim-oai aibrahim-oai force-pushed the dev/fix-main-model-tests branch from 90ed129 to e192d18 Compare April 20, 2026 20:36
@aibrahim-oai aibrahim-oai force-pushed the dev/fix-main-model-tests branch from e192d18 to 545ca7b Compare April 20, 2026 20:51
@aibrahim-oai aibrahim-oai enabled auto-merge (squash) April 20, 2026 20:58
@aibrahim-oai aibrahim-oai merged commit cc96a03 into main Apr 20, 2026
25 checks passed
@aibrahim-oai aibrahim-oai deleted the dev/fix-main-model-tests branch April 20, 2026 21:52
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants