feat: add a built-in Amazon Bedrock model provider#18744
Merged
Conversation
e4ccb7b to
b666344
Compare
Collaborator
Author
|
@codex review |
7efbb43 to
62a553c
Compare
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b666344306
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pakrym-oai
reviewed
Apr 20, 2026
pakrym-oai
reviewed
Apr 20, 2026
pakrym-oai
reviewed
Apr 20, 2026
pakrym-oai
approved these changes
Apr 20, 2026
8b143a6 to
074bf06
Compare
34ed742 to
ad93f1e
Compare
ad93f1e to
d946bfa
Compare
80ee364 to
6f9804a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Codex needs a first-class
amazon-bedrockmodel provider so users can select Bedrock without copying a full provider definition intoconfig.toml. The provider has Codex-owned defaults for the pieces that should stay consistent across users: the displayname, Bedrockbase_url, andwire_api.At the same time, users still need a way to choose the AWS credential profile used by their local environment. This change makes
amazon-bedrocka partially modifiable built-in provider: code owns the provider identity and endpoint defaults, while user config can setmodel_providers.amazon-bedrock.aws.profile.For example:
What Changed
amazon-bedrockto the built-in model provider map with:name = "Amazon Bedrock"base_url = "https://bedrock-mantle.us-east-1.api.aws/v1"wire_api = "responses"model_providers.<id>.aws.profile.amazon-bedrock; custom providers that setawsare rejected.model_providers.amazon-bedrockthrough reserved-provider validation so it can act as a partial override.aws.profileis copied from the user-providedamazon-bedrockentry onto the built-in provider. Other Bedrock provider fields remain hard-coded by the built-in definition.