[codex] Tighten external migration prompt tests#18768
Merged
alexsong-oai merged 4 commits intomainfrom Apr 21, 2026
Merged
Conversation
xl-openai
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
external_agent_config_migrationprompt testsWhy
The previous test fixture used POSIX-style absolute project paths and implicitly relied on
display_path_for()normalizing them to project-relative paths. That assumption held for the non-Windows snapshot, but it did not hold for the failing Windows Cargo run, which rendered absolute project paths instead.This change keeps the test coverage focused on the actual behavior of each platform by feeding Windows-style project paths on Windows and POSIX-style project paths elsewhere.
Validation
just fmtcargo test -p codex-tui external_agent_config_migration::tests::locally, but the build did not complete before I pushed this updateNotes
Per the repo instructions, I did not rerun tests after the final
just fmtpass.