Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 146b095f12
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #[serde(deny_unknown_fields)] | ||
| struct PluginMcpServersFile { | ||
| #[serde(default)] | ||
| mcp_servers: HashMap<String, JsonValue>, | ||
| } | ||
|
|
||
| #[derive(Debug, Deserialize)] | ||
| #[serde(untagged)] | ||
| enum PluginMcpFile { | ||
| McpServersObject(PluginMcpServersFile), | ||
| ServerMap(HashMap<String, JsonValue>), |
There was a problem hiding this comment.
Remove the strict deny_unknown_fields fallback interaction here. For JSON like { "mcpServers": {...}, "$schema": "..." }, PluginMcpServersFile now fails to deserialize, so untagged parsing falls through to ServerMap. That treats mcpServers as a server name, causing valid nested servers to be dropped during normalization. This regresses compatibility while trying to support more file shapes.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Update core-plugins MCP loading to accept either an mcpServers object or a top-level server map in .mcp.json