Queue follow-up input during user shell commands#18820
Merged
etraut-openai merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
fcoury-oai
approved these changes
Apr 21, 2026
Contributor
fcoury-oai
left a comment
There was a problem hiding this comment.
Replicated the issue and confirmed it is fixed in this branch.
Code looks good to me, approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17954.
Why
When a manual shell command like
!sleep 10is running, submitting plain text such ashicurrently sends that text as a steer for the active shell turn. User shell turns are not steerable like model turns, so the TUI can remain stuck inWorkingafter the shell command finishes.What Changed
ExecCommandSource::UserShellcommands.!cmdsubmissions during running work so explicit shell commands keep their existing behavior.!sleep 10plushiflow inchatwidget::tests::exec_flow::user_message_during_user_shell_command_is_queued_not_steered.Verification