Skip to content

feat: baseline lib#18848

Merged
jif-oai merged 2 commits intomainfrom
jif/baseline-lib
Apr 21, 2026
Merged

feat: baseline lib#18848
jif-oai merged 2 commits intomainfrom
jif/baseline-lib

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented Apr 21, 2026

This add with 2 entry point:

  • reset_git_repository that takes a directory and set it as a new git root
  • diff_since_latest_init this returns the diff for a given directory since the last reset_git_repository

@jif-oai
Copy link
Copy Markdown
Collaborator Author

jif-oai commented Apr 21, 2026

@codex review

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

mod apply;
mod branch;
mod errors;
mod ghost_commits;
mod info;
mod operations;
mod platform;

P1 Badge Export the new baseline API from crate root

codex-rs/git-utils/src/baseline.rs adds reset_git_repository and diff_since_latest_init, but src/lib.rs never declares mod baseline; or re-exports these items. That makes the new feature unreachable to crate consumers and prevents its in-file tests from being compiled/run, contradicting the commit’s stated intent to add two entry points.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/git-utils/src/baseline.rs
Comment thread codex-rs/git-utils/src/baseline.rs
Comment thread codex-rs/git-utils/src/baseline.rs
@jif-oai jif-oai merged commit bf2a34b into main Apr 21, 2026
27 of 28 checks passed
@jif-oai jif-oai deleted the jif/baseline-lib branch April 21, 2026 16:24
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant