Fix /review interrupt and TUI exit wedges#18921
Merged
etraut-openai merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
etraut-openai
force-pushed
the
etraut/fix-review-mcp-startup-interrupt
branch
from
d545af3 to
fa445a3
Compare
etraut-openai
changed the title
canvrno-oai
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #11267
Summary
/reviewcan be interrupted while it is still spawning the review sub-agent. That spawn path lives incodex-coreand did not observe the task cancellation token until afterCodex::spawnreturned, so an interrupted review could keep building a child session and leave the TUI in a wedged state.The TUI exit path also waited indefinitely for app-server
thread/unsubscribe, which made Ctrl+C look broken if the app-server was already stuck. This makes interactive delegate startup cancellation-aware and bounds the TUI shutdown-first unsubscribe wait with a short UI escape-hatch timeout.Testing
I reproed the hang using the steps in the bug report. Confirmed hang no longer exists after fix.