TUI: preserve permission state after side conversations#18924
Merged
etraut-openai merged 1 commit intomainfrom Apr 23, 2026
Merged
TUI: preserve permission state after side conversations#18924etraut-openai merged 1 commit intomainfrom
etraut-openai merged 1 commit intomainfrom
Conversation
Update the active thread's cached session permissions when TUI permission settings change so replaying the main thread after /side doesn't restore stale permission state. Add coverage that the active thread snapshot is updated without rewriting side-thread state.
canvrno-oai
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #18854
Why
The
/permissionsselector updates the active TUI session state, but the cached session snapshot used when replaying a thread could still contain the old approval or sandbox settings. After opening and leaving/side, the main thread replay could restore those stale settings into theChatWidget, so the UI and the next submitted turn could fall back to the old permission mode.What
ThreadSessionStatewhenever approval policy, sandbox policy, or approval reviewer changes.Verification
Confirmed bug prior to fix and correct behavior after fix.