chore: remove unused Bedrock auth lazy loading#18948
Merged
Conversation
dda669e to
12459d4
Compare
pakrym-oai
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Bedrock Mantle SigV4 auth provider currently looks like it can lazily load
AwsAuthContext, but the provider is only constructed afterresolve_auth_methodhas already loaded that context. Becausewith_contextalways pre-populates theOnceCell, theget_or_try_initfallback is unused in normal operation and makes the provider lifecycle harder to reason about.This change removes that dead lazy-loading path and makes the actual behavior explicit:
BedrockAuthMethod::AwsSdkAuthcarries only the resolvedAwsAuthContext.BedrockMantleSigV4AuthProviderstores the resolved context directly.OnceCell.The existing eager AWS auth resolution behavior is unchanged; this is a simplification of the provider state, not a behavior change.
Testing
cargo shearcargo test -p codex-model-providerjust bazel-lock-check