Conversation
starr-openai
approved these changes
Apr 22, 2026
Collaborator
Author
|
Windows build seems to keep failing:
|
## Why The post-merge `rust-ci-full` run for #18999 still failed the Ubuntu remote `suite::remote_env` sandboxed filesystem tests. That run checked out merge commit `ddde50c611e4800cb805f243ed3c50bbafe7d011`, so the arg0 guard lifetime fix was present. The remaining gap is that the remote exec-server can pass an arg0 alias path such as `codex-linux-sandbox` as a runtime helper, but the sandboxed filesystem helper only added the real Codex binary parent as a readable runtime root. When bubblewrap re-enters Codex through the alias path, the alias directory also has to be visible inside the sandbox. ## What Changed - Track all helper runtime read roots instead of a single root. - Add both the real Codex executable parent and the `codex-linux-sandbox` alias parent to sandbox readable roots. - Add unit coverage for the alias-parent root. ## Verification - `cargo test -p codex-exec-server` - `just argument-comment-lint -p codex-exec-server` - `just fix -p codex-exec-server`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The post-merge
rust-ci-fullrun for #18999 still failed the Ubuntu remotesuite::remote_envsandboxed filesystem tests. That run checked out merge commitddde50c611e4800cb805f243ed3c50bbafe7d011, so the arg0 guard lifetime fix was present.The Docker-backed failure had two remaining pieces:
codex-linux-sandboxarg0 alias path. The helper sandbox was only granting read access to the real Codex executable parent, so the alias parent also has to be visible inside the helper sandbox.FileSystemSandboxContext::new(), which captures the local test runner cwd. In the Docker remote exec-server, that host checkout path does not exist, so spawning the filesystem helper failed withNo such file or directorybefore the helper could process the request.While validating the PR, the Windows Bazel unit-test shard also exposed a marginal 2s timing assertion in
output_and_exit_are_retained_after_notification_receiver_closes. The test command intentionally waits before emitting output on Windows, so the old deadline could fail under CI load even when the behavior was correct.What Changed
codex-linux-sandboxalias parent to sandbox readable roots.Verification
cargo test -p codex-exec-servercargo test -p codex-exec-server output_and_exit_are_retained_after_notification_receiver_closescargo test -p codex-core remote_test_env_sandboxed_read_allows_readable_rootjust fix -p codex-exec-serverjust fix -p codex-core