Skip to content

guide Windows to use -WindowStyle Hidden for Start-Process calls#19044

Merged
iceweasel-oai merged 4 commits intomainfrom
dev/iceweasel/start-process-hidden-window
Apr 23, 2026
Merged

guide Windows to use -WindowStyle Hidden for Start-Process calls#19044
iceweasel-oai merged 4 commits intomainfrom
dev/iceweasel/start-process-hidden-window

Conversation

@iceweasel-oai
Copy link
Copy Markdown
Collaborator

Sometimes codex runs Start-Process to start up a service or something similar, which launches a user-visible powershell window that probably doesn't get cleaned up. This instruction change encourages it to do so using a hidden window.

This was reported in https://openai.slack.com/archives/C09K6H5DZC4/p1776741272870519

One caveat is that this change won't do anything to cleanup these processes, but it will stop them from polluting the user's visible workspace

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5aea783bc6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/tools/src/local_tool_tests.rs Outdated
iceweasel-oai and others added 2 commits April 22, 2026 15:09
Use the shared Windows guidance helper so the expected exec_command description keeps the blank-line separator before the Windows safety rules.

Co-authored-by: Codex <noreply@openai.com>
@iceweasel-oai iceweasel-oai enabled auto-merge (squash) April 23, 2026 21:25
@iceweasel-oai iceweasel-oai merged commit 2e22896 into main Apr 23, 2026
25 checks passed
@iceweasel-oai iceweasel-oai deleted the dev/iceweasel/start-process-hidden-window branch April 23, 2026 21:36
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants