Skip to content

feat(request-permissions) approve with strict review#19050

Merged
dylan-hurd-oai merged 7 commits intomainfrom
dh--rd--hall-monitor
Apr 23, 2026
Merged

feat(request-permissions) approve with strict review#19050
dylan-hurd-oai merged 7 commits intomainfrom
dh--rd--hall-monitor

Conversation

@dylan-hurd-oai
Copy link
Copy Markdown
Collaborator

Summary

Allow the user to approve a request_permissions_tool request with the condition that all commands in the rest of the turn are reviewed by guardian, regardless of sandbox status.

Testing

  • Added unit tests
  • Ran locally

@dylan-hurd-oai dylan-hurd-oai requested a review from a team as a code owner April 22, 2026 23:15
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 50cd7a4f06

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/core/src/tools/orchestrator.rs Outdated
@dylan-hurd-oai dylan-hurd-oai merged commit 5e71da1 into main Apr 23, 2026
25 checks passed
@dylan-hurd-oai dylan-hurd-oai deleted the dh--rd--hall-monitor branch April 23, 2026 01:56
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants