feat: add hidden background agent auth provider#19054
Open
adrian-openai wants to merge 1 commit intodev/adrian/codex/hai-thread-inference-authfrom
Open
feat: add hidden background agent auth provider#19054adrian-openai wants to merge 1 commit intodev/adrian/codex/hai-thread-inference-authfrom
adrian-openai wants to merge 1 commit intodev/adrian/codex/hai-thread-inference-authfrom
Conversation
This was referenced Apr 22, 2026
a9a1b54 to
684fd95
Compare
abd88cf to
58ac2b5
Compare
684fd95 to
d5d5302
Compare
58ac2b5 to
1902e47
Compare
d5d5302 to
733de44
Compare
1902e47 to
7d2f1cc
Compare
This was referenced Apr 24, 2026
733de44 to
a9fe062
Compare
7d2f1cc to
8deff2e
Compare
a9fe062 to
a3097aa
Compare
8deff2e to
6a19639
Compare
c546eb2 to
c99bc2a
Compare
6a19639 to
ac45ce5
Compare
c99bc2a to
a9b1a6a
Compare
ac45ce5 to
10a4b1f
Compare
a9b1a6a to
360838e
Compare
10a4b1f to
ee7ff88
Compare
360838e to
6205dfe
Compare
ee7ff88 to
5a71f9b
Compare
efrazer-oai
reviewed
Apr 24, 2026
Contributor
efrazer-oai
left a comment
There was a problem hiding this comment.
Any reason to add 'Background' when we already have 'Process'? They seem to do ~the same thing, might be able to cut out a few additions.
Contributor
Author
Good catch @efrazer-oai - let me update this! |
5a71f9b to
2fefd43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
This is PR 4 of the HAI external-task-ref stack:
external_task_ref, and theuse_agent_identityexperimental flag.ThreadIdasexternal_task_refand use taskAgentAssertions.Summary
This PR keeps the temporary background/control-plane auth bridge, but hides it inside auth-provider resolution. Sessionless control-plane callers can ask for Agent Identity auth without seeing task ids, while Codex still avoids adding any background task ids to rollout state, auth-file state, or caller-visible plumbing.
What changed:
Backgroundtaskexternal_task_refAgentAssertionprovidersThis intentionally does not migrate broad backend/control-plane callsites yet; that should be a separate semantic slice once this helper shape lands.
Testing
cargo test -p codex-logincargo test -p codex-model-providerjust fix -p codex-loginjust fix -p codex-model-provider