Skip to content

Clarify cloud requirements error messages#19078

Merged
gverma-openai merged 4 commits intomainfrom
gverma/improve-managed-config-requirements-error-message
Apr 23, 2026
Merged

Clarify cloud requirements error messages#19078
gverma-openai merged 4 commits intomainfrom
gverma/improve-managed-config-requirements-error-message

Conversation

@gverma-openai
Copy link
Copy Markdown
Contributor

@gverma-openai gverma-openai commented Apr 23, 2026

Why

The current cloud-requirements failures say workspace-managed config, which is ambiguous and can read like it refers to local managed config such as managed_config.toml.

This code path only applies to cloud requirements, so the user-facing message should name that source directly.

What changed

  • Updated the load failure in codex-rs/cloud-requirements/src/lib.rs to say failed to load cloud requirements (workspace-managed policies).
  • Updated the parse failure in the same file to use the same cloud requirements (workspace-managed policies) terminology.
  • Kept workspace-managed hyphenated because it is used as a compound modifier.
  • Updated the matching assertion in codex-rs/app-server/src/codex_message_processor.rs.
  • Reused CLOUD_REQUIREMENTS_LOAD_FAILED_MESSAGE in the codex-cloud-requirements test where the test is asserting that crate-local contract directly.

Testing

cargo test -p codex-cloud-requirements

@gverma-openai gverma-openai changed the title Improve cloud requirements error message Clarify cloud requirements error messages Apr 23, 2026
@gverma-openai gverma-openai merged commit 2ef2d67 into main Apr 23, 2026
25 checks passed
@gverma-openai gverma-openai deleted the gverma/improve-managed-config-requirements-error-message branch April 23, 2026 06:07
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants