[codex] Omit fork turns from thread started notifications#19093
Merged
euroelessar merged 1 commit intomainfrom Apr 24, 2026
Merged
[codex] Omit fork turns from thread started notifications#19093euroelessar merged 1 commit intomainfrom
euroelessar merged 1 commit intomainfrom
Conversation
ddr-oai
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
thread/forkresponses intentionally include copied history so the caller can render the fork immediately, butthread/startedis a lifecycle notification. The v2Threadcontract says notifications should returnturns: [], and the fork path was reusing the response thread directly, causing copied turns to be emitted throughthread/startedas well.What Changed
thread/startednotification construction through a helper that clearsthread.turnsbefore sending.thread/forkresponses unchanged so callers still receive copied history.thread/startedemits an emptyturnsarray while the response retains fork history.Testing
just fmtcargo test -p codex-app-server