Skip to content

Reject agents.max_threads with multi_agent_v2#19129

Merged
jif-oai merged 2 commits intomainfrom
jif/error-config
Apr 23, 2026
Merged

Reject agents.max_threads with multi_agent_v2#19129
jif-oai merged 2 commits intomainfrom
jif/error-config

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented Apr 23, 2026

Why

multi_agent_v2 uses the v2 agent lifecycle, so accepting the legacy agents.max_threads limit alongside it creates conflicting configuration semantics. Config load should fail early with a clear error instead of allowing both knobs to be set.

What Changed

  • During config load, detect when the effective multi_agent_v2 feature is enabled and agents.max_threads is explicitly set.
  • Return an InvalidInput error: agents.max_threads cannot be set when multi_agent_v2 is enabled.

Verification

  • cargo test -p codex-core multi_agent_v2_rejects_agents_max_threads passed locally with a temporary focused test for this behavior.
  • cargo test -p codex-core was also run; the new focused path passed, but the crate suite has unrelated pre-existing failures in managed config/proxy/request-permissions tests.

@jif-oai jif-oai requested a review from a team as a code owner April 23, 2026 10:30
@jif-oai jif-oai changed the title feat: error on config Reject agents.max_threads with multi_agent_v2 Apr 23, 2026
@jif-oai jif-oai merged commit d3b0449 into main Apr 23, 2026
25 checks passed
@jif-oai jif-oai deleted the jif/error-config branch April 23, 2026 11:31
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant