Skip to content

exec-server: wait for close after observed exit#19130

Merged
jif-oai merged 1 commit intomainfrom
jif/flake-22
Apr 23, 2026
Merged

exec-server: wait for close after observed exit#19130
jif-oai merged 1 commit intomainfrom
jif/flake-22

Conversation

@jif-oai
Copy link
Copy Markdown
Collaborator

@jif-oai jif-oai commented Apr 23, 2026

Why

Windows CI can flake in server::handler::tests::output_and_exit_are_retained_after_notification_receiver_closes after a process has exited but before both output streams have closed. exec/read returned immediately whenever exited was true, so callers that had already observed the exit event could spin instead of long-polling for the later closed state.

What Changed

  • Keep returning immediately when a terminal exit event is newly observable.
  • Allow later reads, after the caller has advanced past that event, to wait for closed or new output until wait_ms expires.

Verification

  • CI pending.

@jif-oai jif-oai changed the title fix: more flake exec-server: wait for close after observed exit Apr 23, 2026
@jif-oai jif-oai merged commit 45e1742 into main Apr 23, 2026
25 checks passed
@jif-oai jif-oai deleted the jif/flake-22 branch April 23, 2026 14:50
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants