Add conditional network proxy prompt guidance#19176
Open
viyatb-oai wants to merge 3 commits into
Open
Conversation
350e69e to
6137d0b
Compare
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex noreply@openai.com
6137d0b to
8cd5eec
Compare
Co-authored-by: Codex noreply@openai.com
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a network proxy is active, the model needs enough context to keep proxy routing intact, distinguish explicit policy denials from ordinary network failures, and know when to request more network permission instead of trying to work around the sandbox. Without that guidance, it can misread proxy-mediated failures or override the environment that is enforcing policy.
What changed
# Network Proxysection to the permissions instructions bundle when the current turn actually has an active proxy.<network>allow/deny entries, preserve proxy-related environment variables, and request more network permission for hosts outside policy.blocked-by-allowlist,blocked-by-denylist, and local/private target blocks) while clarifying that proxy-mediated clients can also time out or hang, so generic failures alone are not proof of a proxy denial.PermissionsInstructionOptions.Testing
cargo test -p codex-core includes_network_proxy_guidance_when_proxy_is_activecargo test -p codex-core permissions_message_includes_writable_rootscargo clippy -p codex-core --all-targets -- -D warnings