[codex] Forward Codex Apps tool call IDs to backend metadata#19207
Merged
rreichel3-oai merged 4 commits intomainfrom Apr 24, 2026
Merged
[codex] Forward Codex Apps tool call IDs to backend metadata#19207rreichel3-oai merged 4 commits intomainfrom
rreichel3-oai merged 4 commits intomainfrom
Conversation
Update the Codex Apps file MCP integration test to expect the forwarded outer tool call ID in _meta._codex_apps. This keeps the suite aligned with the new client metadata contract used by the paired backend compliance logging change.
Update the deferred-tool search integration test to expect the forwarded outer tool call ID in Codex Apps metadata. This keeps the search-tool flow aligned with the same _meta._codex_apps contract exercised by the direct MCP tool call tests.
mzeng-openai
approved these changes
Apr 24, 2026
bolinfest
reviewed
Apr 24, 2026
| let meta = build_mcp_tool_call_request_meta( | ||
| &turn_context, | ||
| "custom_server", | ||
| "call-custom", |
Collaborator
There was a problem hiding this comment.
I know this is a test, but isn't a more representative call_id something like "call_abc123xyz789"?
Contributor
Author
There was a problem hiding this comment.
Fixed, thanks for the callout
bolinfest
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
call_idin Codex Apps MCP request metadata under_meta._codex_apps.call_idresource_uriandcontains_mcp_sourceWhy
The paired backend change in openai/openai#850796 updates MCP compliance logging to prefer
_meta._codex_apps.call_idinstead of the JSON-RPC request id. This client change sends that outer tool call id so the backend can record the model/tool call identifier when it is available.This is wire-compatible with older backends because
_meta._codex_appsis already reserved backend-only metadata. Backends that do not readcall_idwill ignore the extra field.Testing
cargo test -p codex-core request_metajust fmtjust fix -p codex-core