Add agent graph store interface#19229
Merged
rasmusrygaard merged 4 commits intomainfrom Apr 29, 2026
Merged
Conversation
rasmusrygaard
commented
Apr 24, 2026
| .upsert_thread_spawn_edge(parent_thread_id, child_thread_id, to_state_status(status)) | ||
| .await | ||
| .map_err(internal_error) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Implementation should match what's already in the repo. Will point those callers at this code eventually
jif-oai
approved these changes
Apr 29, 2026
d5ec021 to
ce284b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Persisted subagent parent/child topology currently leaks through
StateRuntime's SQLite-specific thread-spawn helpers. This PR introduces a narrowAgentGraphStoreboundary so follow-up work can route graph operations through a local or remote store without coupling orchestration code directly to the state DB graph API.Changes
codex-agent-graph-storecrate.AgentGraphStoretrait for the v1 graph surface: upsert edge, set edge status, list direct children, and list descendants.ThreadSpawnEdgeStatus,AgentGraphStoreError, andAgentGraphStoreResult.LocalAgentGraphStoreon top of an existingcodex_state::StateRuntime, preserving today's SQLite-backedthread_spawn_edgesbehavior.This PR only adds the local contract and implementation; call-site migration and the remote gRPC store are left to the follow-up PRs in the stack.
Testing
cargo test -p codex-agent-graph-storeThe new unit tests cover local parity with the existing
StateRuntimegraph methods,Open/Closedfiltering, status updates, and stable breadth-first descendant ordering.