fix: allow AgentIdentity through Apps MCP gates#19240
Draft
efrazer-oai wants to merge 1 commit intodev/efrazer/agent-identity-env-jwtfrom
Draft
fix: allow AgentIdentity through Apps MCP gates#19240efrazer-oai wants to merge 1 commit intodev/efrazer/agent-identity-env-jwtfrom
efrazer-oai wants to merge 1 commit intodev/efrazer/agent-identity-env-jwtfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #18811 routes Codex backend auth through
AuthProvider, and PR #18904 adds AgentIdentity JWT login/env support on top. The Apps MCP refresh path still had a few enablement gates that only accepted token-backed ChatGPT auth.This PR changes those gates to use
CodexAuth::uses_codex_backend, matching the rest of the auth-provider migration. AgentIdentity can now reach the Apps MCP refresh path and plugin Apps follow-up flow instead of returning an empty connector list before the provider-backed auth is used.Stack
Call sites
core/src/connectors.rs::list_cached_accessible_connectors_from_mcp_toolsuses_codex_backendbefore reading cached Apps MCP connectors.core/src/connectors.rs::list_accessible_connectors_from_mcp_tools_with_environment_manageruses_codex_backendbefore constructing the Apps MCP manager with provider-backed auth.app-server/src/codex_message_processor/plugins.rsuses_codex_backendwhen deciding whether newly installed plugin Apps need auth follow-up.Tests
Tests: focused Rust formatting, scoped cargo check, and scoped clippy fix pass for touched packages.